Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-8091 Fix ktor-client-curl publishing #4618

Merged
merged 1 commit into from
Jan 20, 2025
Merged

KTOR-8091 Fix ktor-client-curl publishing #4618

merged 1 commit into from
Jan 20, 2025
+4 −3

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Jan 20, 2025

Subsystem
Infrastructure

Motivation
KTOR-8091 ktor-client-curl artifacts aren’t published after EAP 1146

Solution
Aggregating tasks relay on the flags declared in TargetsConfig. Unfortunately, these flags were out of sync a bit (#4616 should fix this problem) and this caused ktor-client-curl not to be published.

private fun Project.configureAggregatingTasks() {
    // ...
    // These three were false if only "desktop" source-set is present.
    if (hasLinux) registerAggregatingTask("Linux", linuxTargets)
    if (hasWindows) registerAggregatingTask("Windows", windowsTargets)
    if (hasDarwin) registerAggregatingTask("Darwin", darwinTargets)
    // ...
}

@osipxd osipxd self-assigned this Jan 20, 2025
bjhham
bjhham approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a Venn diagram for all these targets 😂

@osipxd
Copy link
Member Author

osipxd commented Jan 20, 2025

I think we need a Venn diagram for all these targets 😂

After #4616 it won't be needed anymore. I've implemented programmatic tracking of relations between targets and their groups.

@osipxd osipxd force-pushed the osipxd/curl-publishing branch from f8788f1 to e4982c3 Compare January 20, 2025 12:32
@osipxd osipxd enabled auto-merge (squash) January 20, 2025 12:32
@osipxd osipxd merged commit 32b6578 into main Jan 20, 2025
16 checks passed
@osipxd osipxd deleted the osipxd/curl-publishing branch January 20, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhham bjhham bjhham approved these changes

Assignees

@osipxd osipxd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osipxd @bjhham